Removing text prefix that makes the log an invalid json#72
Merged
shesek merged 2 commits intoBlockstream:new-indexfrom Mar 19, 2024
rem1-dev:rpc-logging-update
Merged
Removing text prefix that makes the log an invalid json#72shesek merged 2 commits intoBlockstream:new-indexfrom rem1-dev:rpc-logging-update
shesek merged 2 commits intoBlockstream:new-indexfrom
rem1-dev:rpc-logging-update
Conversation
shesek
approved these changes
Mar 19, 2024
junderw
pushed a commit
to junderw/electrs
that referenced
this pull request
May 1, 2024
Fix: Liquid sigops was trying to count for pegins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELECTRUM-RPC-LOGGER:prefix causes problem because with it included in the log line the log interpreted as a json is invalid. Therefore a preprocessing that removes this prefix, or reads json with an offset from the log, should be used to fix it. However I think it's better to remove this log prefix.